Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings): add peerDependencies for npm #3126

Merged
merged 3 commits into from Mar 10, 2024

Conversation

ObserverOfTime
Copy link
Member

Also add the "files" array if missing.

Requires #3109 and the node-tree-sitter update.

@ObserverOfTime ObserverOfTime force-pushed the peer-deps branch 2 times, most recently from b3bd4e9 to 2faa1ea Compare March 4, 2024 10:16
@ObserverOfTime ObserverOfTime force-pushed the peer-deps branch 2 times, most recently from a6a5313 to 3ba21db Compare March 9, 2024 17:49
@ObserverOfTime
Copy link
Member Author

I'm afraid I don't know enough rust to fix this.

error[E0499]: cannot borrow `package_json` as mutable more than once at a time
   --> cli/src/generate/grammar_files.rs:143:40
    |
121 |                 let dependencies = package_json
    |                                    ------------ first mutable borrow occurs here
...
143 |                 let dev_dependencies = package_json
    |                                        ^^^^^^^^^^^^ second mutable borrow occurs here
...
150 |                     dependencies.insert(
    |                     ------------ first borrow later used here

@ObserverOfTime ObserverOfTime force-pushed the peer-deps branch 2 times, most recently from 5e67dd1 to 847be31 Compare March 10, 2024 12:44
@ObserverOfTime ObserverOfTime marked this pull request as ready for review March 10, 2024 12:44
Co-Authored-By: Amaan Qureshi <amaanq12@gmail.com>
@amaanq amaanq merged commit b60b248 into tree-sitter:master Mar 10, 2024
13 checks passed
@ObserverOfTime ObserverOfTime deleted the peer-deps branch March 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants