Resolving a crash when freeing a null pointer when cancelling parses #1938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a potential crash we've seen in parser.c.
If a parse is in progress, in certain cases, the
lookahead.ptr
pointer can beNULL
when the code reaches src/parser.c#L. This will only actually crash if the cancellation token happens to have been set to a non-zero value.This request contains a check to ensure that
lookahead.ptr
is notNULL
before releasing the subtree.I'm not entirely up on all of the potential branch cases and other code with which this might interact, so I'm happy for a review to ensure this is an acceptable fix!
Thank you!