Derive Hash for Language #2080
Merged
Derive Hash for Language #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given Language implements Eq, it can probably implement Hash too. This makes it easy to derive a random identifier from a `Language`
|
Thanks! |
|
Well, thank you for the quick merge and work on tree-sitter! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Language implements Eq, it can probably implement Hash too.
This makes it easy to derive a random identifier from a
LanguageFor some context, I'm currently writing a creduce-like based on tree-sitter (not yet ready for prime time, though
cargo run --bin rsreducealready kinda works), and am trying to derive a random identifier for passes so that the user can know which log lines refer to the same pass. Among the things in a pass is theLanguage, and though I could just not hash it, I don't see any reason not to :)