No flaky tests - make all tests run in a reliable way; V2 #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to omit occurrences of the same seed in a sequence of following seeds due to the reason of that two initial seed are very close if based on unix epoch seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a set of tests that depend on a timeout or a random seed that controls edits in corpus tests. All such tests are flaky and from time to time fail CI in unexpected places on random PR branches or on the master branch or even during a release process 馃く.
There was an attempt to fix tests reliability:
But it was based on a custom runner and didn't properly resolve the issue.
This PR completely solves the issue by introducing several proc macros that run all flaky tests with 10 retries.
Changes:
ddb0af9 test: use random SEED numbers
This is needed to omit occurrences of the same seed in a sequence of
following seeds due to the reason of that two initial seeds are very
close if based on unix epoch seconds.
3aeef44 test: run all corpus tests with 10 retries
588549c test: run
test_parsing_with_a_timeoutwith 10 retries62f8c43 test: add
retryandtest_with_seedproc macros