fix: disallow tokens that match the empty string #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
force-pushed
the
disallow-empty-tokens
branch
5 times, most recently
from
a0ce0bc
to
810cf77
Compare
This comment was marked as spam.
This comment was marked as spam.
ahlinc
suggested changes
Aug 1, 2023
|
@amaanq could you add grammar tests for cases that were issues before? To avoid regressions in the future. |
amaanq
force-pushed
the
disallow-empty-tokens
branch
3 times, most recently
from
4d1cf80
to
418d487
Compare
This keeps the behavior the same as non-token rules, and prevents an infinite loop bug
amaanq
force-pushed
the
disallow-empty-tokens
branch
from
418d487
to
2146726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the behavior the same as non-token rules, and prevents an infinite loop bug
Closes #98
Closes #1111
Closes #1271
Fixes the memory explosion cases in #1156