feat: implement first-line-regex #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
reviewed
Aug 8, 2023
|
Also a test or two could be useful if you don't mind adding that |
|
todo
|
|
I applied your suggestion and added a test |
sigmaSd
commented
Aug 8, 2023
amaanq
force-pushed
the
flr
branch
2 times, most recently
from
9970043
to
0d291f9
Compare
ahlinc
suggested changes
Aug 8, 2023
amaanq
force-pushed
the
flr
branch
4 times, most recently
from
857c70d
to
20d3d70
Compare
|
thanks, sorry for taking so long to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2478
I added a PR for helix for the same thing helix-editor/helix#7853
But there I went with a Vec instead of a String, the example is strace output it can start with
["execve", ,"^[0-9:.]* *execve", "^__libc_start_main"]Obviously this is not a structured language by any mean (though I wrote a wip grammar for it) so it might be an invalid argument