chore(build-wasm): use spawn instead of output to give feedback #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonyashines
approved these changes
Aug 13, 2023
|
emcc shows a warning Any idea how to disable/fix it ? |
|
the ci seems to have no error ? |
|
I'll add more functionality to this PR, that's why I assigned it myself. |
Co-authored-by: Nbiba Bedis <bedisnbiba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the user uses
build-wasmhe have no feedback on whats happening, and this command can take a while mainly the first time since its pulls the docker image.This PR spawn the command instead so the user can see whats happening live.