fix: makefile should install only api.h header
#2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
approved these changes
Aug 26, 2023
ahlinc
added a commit
that referenced
this pull request
Aug 26, 2023
fix: makefile should install only `api.h` header
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 31, 2023
>=tree-sitter-0.20.8-r1 doesn't install parser.h anymore because it may be mismatched with the version used to build the parser. Use one bundled with rizin-shell-parser instead. This should propagate into rizin-shell-parser when they regenerate with a newer tree-sitter release (once one is made). See also: * tree-sitter/tree-sitter#2573 * tree-sitter/tree-sitter#2574 Bug: https://bugs.gentoo.org/912716 Closes: https://bugs.gentoo.org/913343 Signed-off-by: Sam James <sam@gentoo.org>
|
Can we revert this? Semgrep needs the tree-sitter.h to compile semgrep. |
|
We shouldn't revert this, api.h is the only relevant file for users to interact with when installing the lib - parser.h is more internal and is meant for a grammar's parser/scanner to consume, not front-facing users I would say there's an issue with semgrep's build process if it's breaking the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue raised in tree-sitter/tree-sitter-bash#199 (comment)
Because Gentoo distributive solely relies on Tree-sitter's Makefile and got an issue due to an issue in the Makefile.