fix(cli): cannot install via a HTTP tunnel proxy #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
force-pushed
the
install_behind_proxy
branch
from
a746630
to
a8b4dce
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the install script in
cli/npmis not handling the HTTP proxy correctly, so I make a simple fix for that.The proxy usage in former version is ok when the destination is a HTTP (without the
S) website, but the install script will download tree-sitter binary file from GitHub by HTTPS protocol (which is good and I wouldn't to switching it to HTTP).Using HTTP proxy as a tunnel (the HTTP
CONNECTmethod) is the right way to do this. AFAIK all HTTP proxy implementation support theCONNECTmethod, this fix should be ok for all users.