Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use lockfiles to dedup recompilation #2953

Merged
merged 2 commits into from Feb 12, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Feb 7, 2024

This is a simplified rewrite of #2647, without adding a multithreaded option to the cli and without deriving clone unnecessarily, that was a bad mistake I made there but I did that to spark the conversation as to why that might be, I wasn't 100% sure back then.

I think testing grammars that parse large repos will benefit immensely anyways from having a -j flag that tells the cli how many threads to run parsing on, it does help a lot when it's in the order of magnitude of minutes. This is the first step in getting that potentially done, but is also great in that it fixes the spurious racy CI failures which happen when one test compiles a parser and the other attempts to load it when it's partially been written to the fs.

fs4 also seems to be actively maintained, unlike the fs2 crate in the previous PR

@amaanq
Copy link
Member Author

amaanq commented Feb 7, 2024

Ok, macos-x86 failed 3x in a row on an async test which is super weird - I need to investigate that more, those tests might just be poorly written tbh.

@amaanq amaanq force-pushed the lockfile-pt2 branch 3 times, most recently from cb6cd69 to 8abb33f Compare February 12, 2024 08:34
@amaanq amaanq merged commit 39df8e2 into tree-sitter:master Feb 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants