feat: use lockfiles to dedup recompilation #2953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simplified rewrite of #2647, without adding a multithreaded option to the cli and without deriving clone unnecessarily, that was a bad mistake I made there but I did that to spark the conversation as to why that might be, I wasn't 100% sure back then.
I think testing grammars that parse large repos will benefit immensely anyways from having a
-j
flag that tells the cli how many threads to run parsing on, it does help a lot when it's in the order of magnitude of minutes. This is the first step in getting that potentially done, but is also great in that it fixes the spurious racy CI failures which happen when one test compiles a parser and the other attempts to load it when it's partially been written to the fs.fs4 also seems to be actively maintained, unlike the fs2 crate in the previous PR