fix: don't log NUL characters #3037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphviz dot will fail with this character present
theHamsta
reviewed
Feb 17, 2024
| @@ -997,7 +997,7 @@ void ts_subtree__print_dot_graph(const Subtree *self, uint32_t start_offset, | |||
| ts_subtree_lookahead_bytes(*self) | |||
| ); | |||
|
|
|||
| if (ts_subtree_is_error(*self) && ts_subtree_child_count(*self) == 0) { | |||
| if (ts_subtree_is_error(*self) && ts_subtree_child_count(*self) == 0 && self->ptr->lookahead_char != 0) { | |||
| fprintf(f, "\ncharacter: '%c'", self->ptr->lookahead_char); | |||
| } | |||
There was a problem hiding this comment.
Shouldn't we a print a replacement character here e.g.NUL or \0
There was a problem hiding this comment.
Yeah maybe, well \0 itself wouldn't work but escaping it like \\0 would if that's what you mean. I initially just thought about the EOF case but there's also some languages where the nul byte is valid in certain spots as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphviz dot will fail with this character present
Closes #709