fix: apply some scan-build
suggestions (unused assignment/garbage access)
#3056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. found_token is assigned without the prior value being used, last_entry might never be set in the loop if it always evaluates to false, etc
scan-build make
is pretty neat, but the potential null pointer deref stuff seemed sane to me at a glance for the most part based on conditions/factors clang can't intelligently know