Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.swift: move 'cLanguageStandard' behind 'targets' #3101

Merged
merged 1 commit into from Feb 28, 2024

Conversation

JmPotato
Copy link
Contributor

Before this PR:

> swift build
Updating https://github.com/tree-sitter/tree-sitter.git
Updated https://github.com/tree-sitter/tree-sitter.git (1.29s)
error: Invalid manifest (compiled with: ["/Library/Developer/CommandLineTools/usr/bin/swiftc", "-vfsoverlay", "/var/folders/x_/z7jrp4m90z948c1n3qnzfmt80000gn/T/TemporaryDirectory.1y3Gmk/vfs.yaml", "-L", "/Library/Developer/CommandLineTools/usr/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Library/Developer/CommandLineTools/usr/lib/swift/pm/ManifestAPI", "-target", "arm64-apple-macosx13.0", "-sdk", "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk", "-swift-version", "5", "-I", "/Library/Developer/CommandLineTools/usr/lib/swift/pm/ManifestAPI", "-sdk", "/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk", "-package-description-version", "5.8.0", "/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/x_/z7jrp4m90z948c1n3qnzfmt80000gn/T/TemporaryDirectory.Jppl9X/tree-sitter-manifest"])
/Package.swift:15:5: error: argument 'targets' must precede argument 'cLanguageStandard'
    targets: [
~~~~^~~~~~~~~~ in https://github.com/tree-sitter/tree-sitter.git

After this PR:

> swift build
Fetching https://github.com/JmPotato/tree-sitter.git from cache
Fetched https://github.com/JmPotato/tree-sitter.git (0.99s)
Creating working copy for https://github.com/JmPotato/tree-sitter.git
Working copy of https://github.com/JmPotato/tree-sitter.git resolved at fix_swift_package

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@amaanq amaanq merged commit aeefb99 into tree-sitter:master Feb 28, 2024
@amaanq
Copy link
Member

amaanq commented Feb 28, 2024

thanks

@JmPotato JmPotato deleted the fix_swift_package branch February 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants