fix: don't use __declspec(dllexport) on windows
#3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbrunsfeld
reviewed
Mar 4, 2024
| @@ -1346,7 +1346,7 @@ impl Generator { | |||
| add_line!(self, "#endif"); | |||
| add_line!(self, ""); | |||
| add_line!(self, "#ifdef _WIN32"); | |||
| add_line!(self, "#define TS_PUBLIC __declspec(dllexport)"); | |||
| add_line!(self, "#define TS_PUBLIC"); | |||
There was a problem hiding this comment.
Do we need this whole TS_PUBLIC thing at all in the generated parsers? I don't remember what issue it solved, and it looks like on non-windows platforms, it just setting visibility to default.
There was a problem hiding this comment.
it's so if anyone decides to compile with -fvisibility=hidden the symbols are still exported anyways. sometimes it's nice to reduce the noise/visible symbols from the lib or parser, which might stem from the enums/symbol names in parser.c.
|
Looks like CI failed on windows not being to load symbols. You sure this PR was correct? |
|
Yeah the line change in render.rs was a stupid mistake (and not really intentional, slipped my mind), oops. Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using this makes every other symbol hidden by default; for whatever reason microsoft exposes every symbol unless
__declspec(dllexport)is used, then only those marked with this are exportedCloses #3127