Remove dependency on which crate #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were just using it to check if
emcc,docker, andpodmanwere available, but that can be done more simply, by just invoking the commands and checking the result.Soon, I may switch the wasm compilation to use
wasi-sdkinstead of emscripten anyway. At that point, I would just have the CLI downloadwasi-sdkautomatically, instead of checking if it were on the PATH.MSRV
Unfortunately, even after removing
which, our MSRV is still limited to >= 1.74, due to theclap_builderdependency.