Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Compiling a parser with
-pedantic
warns that theREDUCE
macro must have at least one variadic argument. This is innocuous since the macro does not expand into a function call, which prohibits trailing commas, but into a struct initialiser, where they are allowed. The warning can be silenced in clang but not in GCC. (MSVC doesn't care.)Solution
Move all arguments into the variadic list.
Closes #3227
Alternatives
Separate into a macro with arguments and one without
That would make the generator more complicated.
Change the std to
gnu11
No reason to do that just for this easily fixable warning.