Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR deals with tree queries, introduced in #444
Currently, there is a fair amount of duplication in some of our highlighting and tagging queries. Some of this could be avoided if Tree queries had a notion of alternation - writing a sub-pattern that matches any one of a list of possible patterns. This PR adds a general alternation syntax to Tree queries.
Syntax
An alternation is written as a pair of square brackets containing a list of alternative patterns. Using square brackets seems practical because:
(
)
delimiters[abc]
, which matches eithera
,b
, orc
.Alternations are (I believe) fully composable with the other syntax constructs in queries (captures,
+
,*
, and?
, etc).Examples
All of these examples are for the JavaScript language:
@function
. If it is a property, capture it as@method
.@function
. In the case of a property, capture it as@method
.@keyword
.