Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS clip property is deprecated #25

Closed
srinivasdamam opened this issue Apr 16, 2018 · 2 comments
Closed

CSS clip property is deprecated #25

srinivasdamam opened this issue Apr 16, 2018 · 2 comments

Comments

@srinivasdamam
Copy link
Contributor

There is the mdn link about this.

There are couple of places where clip is used like this.

clip: rect(0,0,0)

Same can be achieved with this.

visibility: hidden

Shall I raise a PR for this?
srinivasdamam added a commit to srinivasdamam/leaf-ui that referenced this issue Apr 16, 2018
@srinivasdamam
refactor(Checkbox/Input and Radio/Input): Use visibility as hidden in…
819499f 
…stead of clip property

CSS clip property is deprecated. To acheive the same what clip is doesat present I have set
visibilty as hidden

treebohotels#25
@srinivasdamam srinivasdamam mentioned this issue Apr 16, 2018
Merged
@whilelucky
Copy link
Contributor

Hey @srinivasdamam, the visibility: hidden approach unfortunately won't work as intended in this case. Hiding the native checkbox and radio buttons from the browser with this approach no longer let's you use the Tab or Arrow Up / Down keys to navigate between them in focused states.

We require all form inputs to be keyboard navigable, since it's crucial to our accessibility guidelines.

Maybe there's a different way you could approach this while still maintaining keyboard support? We would definitely be open that :)

@srinivasdamam
Copy link
Contributor Author

I updated the PR #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whilelucky @srinivasdamam