Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting map crashes - uncomplete installation (Java) #96

Closed
pixelhomie opened this issue Feb 22, 2022 · 6 comments
Closed

Converting map crashes - uncomplete installation (Java) #96

pixelhomie opened this issue Feb 22, 2022 · 6 comments
Labels
uncomplete installation Installation was not carried out like described in docs/

Comments

@pixelhomie
Copy link

Expected Behavior

Map should be converted for Wahoo Device

Current Behavior

Converting fails

Steps to Reproduce the Issue

  1. Downloaded latest Anaconda / wahooMapsCreator Version
  2. Extracted wahooMapsCreator to D:\wahooMapsCreator
  3. Created Anaconda environment inside wahooMapsCreator Dir conda env create --prefix ./envs -f ./conda_env/enduser.yml
  4. Activated profile conda activate D:\wahooMapsCreator\envs
  5. Started create process python wahoo_map_creator.py

Context

  • OS/Platform: Windows 10, Anaconda, wahooMapsCreator v.1.0.0

Log Output / Stack Trace

python wahoo_map_creator.py
+ Input country or json file: germany.

# Read json file
+ Use json file D:\wahooMapsCreator\common_resources\json\europe\germany.json with 57 tiles
# Read json file: OK

# check D:\wahooMapsCreator\common_download\land-polygons-split-4326\land_polygons.shp file
# D:\wahooMapsCreator\common_download\land-polygons-split-4326\land_polygons.shp file needs to be downloaded
# Downloading land_polygons.shp file
+ Downloaded: D:\wahooMapsCreator\common_download\land-polygons-split-4326\land_polygons.shp
# check land_polygons.shp file: OK

# check countries .osm.pbf files
+ Checking for old maps and remove them
+ Trying to download missing map of germany.
# Downloading germany-latest.osm.pbf file
+ Downloaded: D:\wahooMapsCreator\common_download\maps\germany-latest.osm.pbf
# Check countries .osm.pbf files: OK

# Filter tags from country osm.pbf files

+ Converting map of germany to o5m format
Traceback (most recent call last):
  File "wahoo_map_creator.py", line 41, in <module>
    oOSMmaps.filter_tags_from_country_osm_pbf_files()
  File "D:\wahooMapsCreator\common_python\osm_maps_functions.py", line 143, in filter_tags_from_country_osm_pbf_files
    result = subprocess.run(cmd, check=True)
  File "D:\wahooMapsCreator\envs\lib\subprocess.py", line 512, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['D:\\wahooMapsCreator\\tooling_windows\\osmconvert', '-v', '--hash-memory=2500', '--complete-ways', '--complete-multipolygons', '--complete-boundaries', '--drop-author', '--drop-version', 'D:\\wahooMapsCreator\\common_download\\maps\\germany-latest.osm.pbf', '-o=D:\\wahooMapsCreator\\output\\outFile-germany.o5m']' returned non-zero exit status 3221225781.
@pixelhomie pixelhomie added the bug Something isn't working label Feb 22, 2022
@treee111
Copy link
Owner

Hi! thanks for reaching out and wirting this issue!
Glad you managed to install it.

I was able to reproduce this error on a freshly installed Windows and opened #85 some time ago.
I would be happy if you could test the fix I provided!

It is included with that release: https://github.com/treee111/wahooMapsCreator/releases/tag/latest
or via pulling this branch fix-osmconvert https://github.com/treee111/wahooMapsCreator/tree/fix-osmconvert

As you have setup everything already you can copy the comon_download folder into the newly downloaded folder. Then just start wahooMapsCreator in the new folder via Anaconda Prompt / cmd!

@pixelhomie
Copy link
Author

pixelhomie commented Feb 23, 2022 via email

@treee111
Copy link
Owner

treee111 commented Feb 23, 2022

Glad to hear! Yes I am also German :-)

Have you install java as written in the setup guide? This part is collapsed. Maybe I have to change that layout...
https://github.com/treee111/wahooMapsCreator/blob/develop/docs/QUICKSTART_ANACONDA.md#windows-macos-linux

You can also join this telegram group and we can chat directly!
https://t.me/joinchat/TaMhjouxlsAzNWZk

@pixelhomie
Copy link
Author

pixelhomie commented Feb 24, 2022 via email

@treee111
Copy link
Owner

Hi Bastian,

freut mich, dass es mit Java geklappt hat. Die Standard-Fehlermeldung war an der Stelle hilfreich.
Das war so eingeklappt in der docs/QUICKSTART_ANACONDA.md Datei:
image

Das habe ich nun geändert, jetzt ist alles direkt sichtbar.

Die README.md gibt einen groben Überblick, die QUICKSTART_ANACONDA.md zeigt die initiale Installation (Schritt-für-Schritt) und USAGE.md ausführlicher, wie man das Tool benutzt. Die verfügbaren CLI-Parameter habe ich nicht alle beschrieben, da ich denke die meisten User nutzen die GUI.

Was fehlt dir da genau?

Hier im Repo meint OSM Tag die Inhalte auf der generierten Karte, also Straßen, Stadtnamen etc. Die werden in die Karte reingeschrieben je nach Konfiguration. Mehr dazu hier: https://github.com/treee111/wahooMapsCreator/blob/develop/docs/TAGS_ON_MAP_AND_DEVICE.md

Hast du an das gleiche oder was anderes gedacht?

Das python3 habe ich nun überall gelöscht.
Das kam aus den Anfangszeiten auf macOS, dort ist standardmäßig Python 2.7 oder so installiert da hat man das gebraucht wenn ich mich korrekt erinnere. Habe ich aber Ewigkeiten nicht mehr benutzt und mit Anaconda wird 3.X installiert.

Ebenso habe ich die Anaconda Environment Anleitung umgeschrieben, dass die Env im Standard Anaconda Ordner und nicht im Repo erstellt wird. Ich dachte mal es wäre besser im Repo aber wenn man neue Versionen etc. nutzt ist das nervig.

Vielen Dank für deinen Input! 👍

Viele Grüße
Benjamin

@treee111
Copy link
Owner

closing due to inactivity

@treee111 treee111 changed the title Converting map crashes Converting map crashes - Java was not installed Apr 26, 2023
@treee111 treee111 changed the title Converting map crashes - Java was not installed Converting map crashes - uncomplete installation (Java) Apr 26, 2023
@treee111 treee111 added uncomplete installation Installation was not carried out like described in docs/ and removed bug Something isn't working labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
uncomplete installation Installation was not carried out like described in docs/
Projects
None yet
Development

No branches or pull requests

2 participants