Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] Refactor tags constants, have universal tags and unittest it #108

Merged
merged 6 commits into from
Apr 21, 2022
Merged

[DEV] Refactor tags constants, have universal tags and unittest it #108

merged 6 commits into from
Apr 21, 2022

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Apr 19, 2022 •
edited

This PR…

  • reduces the tags in the constants.py file to only one set
  • introduces a function to convert from the set to OS specific format
  • massively unittests the new function to convert the tags to the OS specific format

Considerations and implementations

How to test

  1. run unittests
  2. run the tool for your country/tile

Pull Request Checklist

@treee111
introduction of universal tags to keep constant
8d9f0f4 
- first simple function and unittests
@treee111
further adjust universal tags to keep constant
d57bf38 
- advanced function and new unittests + class
@treee111
further adjust universal tags to keep constant
6213fd0 
- full function and new unittests
@treee111
adjust translate function and unittests
f5115e1 
- mocking
@treee111
use new function
6c387e9
@treee111
update split-<country> unittest file
8524679 
- due to change in "to keep tags": 'wetland  =wood' to 'wetland', 'wood'
@treee111 treee111 changed the title [DEV] Refactor tags constants [DEV] Refactor tags constants, have universal tags and unittest it Apr 19, 2022
@mweirauch
Copy link
Contributor

Works on my side (Fedora). Tested with python ./wahoo_map_creator.py cli -c -km -xy 136/84 -t tag-wahoo_custom.xml.

@treee111
Copy link
Owner Author

Works on my side (Fedora). Tested with python ./wahoo_map_creator.py cli -c -km -xy 136/84 -t tag-wahoo_custom.xml.

thanks for checking! 👍

@treee111 treee111 merged commit df80946 into develop Apr 21, 2022
@treee111 treee111 deleted the refactor-tags-constants branch April 21, 2022 20:16
@treee111 treee111 mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweirauch mweirauch mweirauch left review comments

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@treee111 @mweirauch