Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] cut down folder_name to 50 to not crash when creating output folder #228

Merged
merged 4 commits into from
Nov 17, 2023
Merged

[FIX] cut down folder_name to 50 to not crash when creating output folder #228

merged 4 commits into from
Nov 17, 2023

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Nov 10, 2023 •
edited
Loading

This PR…

Considerations and implementations

This is the main body of the PR, and varies massively by PR. A simple PR may have a single sentence here, others may have multiple paragraphs, diagrams, etc.

{...}

How to test

  1. ...
  2. ...

Pull Request Checklist

@treee111 treee111 changed the title cut down folder_name to 50 to not crash when creating output folder [FIX] cut down folder_name to 50 to not crash when creating output folder Nov 10, 2023
@treee111 treee111 linked an issue Nov 10, 2023 that may be closed by this pull request
Output folder name is too long #227
Closed
@treee111 treee111 closed this Nov 10, 2023
@treee111 treee111 reopened this Nov 11, 2023
@7FM 7FM mentioned this pull request Nov 14, 2023
Closed
@treee111 treee111 marked this pull request as ready for review November 17, 2023 15:34
@treee111
Copy link
Owner Author

confirmed to work: #227 (comment)

@treee111 treee111 merged commit 866bbaa into release-v4.1.1 Nov 17, 2023
3 checks passed
@treee111 treee111 deleted the fix-output-folder-length branch November 17, 2023 15:35
@treee111 treee111 mentioned this pull request Nov 19, 2023
Merged
4 tasks
treee111 added a commit that referenced this pull request Mar 22, 2024
@treee111
[FIX] cut down folder_name to 50 to not crash when creating output fo…
ea05ae2 
…lder (#228)

* cut down folder_name to 50 to not crash when creating output folder

fixes #227

* Bump to version 4.1.1a0

* add "_and_more" if folder name is cutted

* Bump to version 4.1.1a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output folder name is too long
1 participant
@treee111