[FEATURE] Add check for required input parameter for CLI and GUI #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- now not only for GUI but also for CLI the country argument is checked
treee111
changed the title
treee111
added a commit
that referenced
this pull request
Oct 19, 2021
- now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error.
treee111
added a commit
that referenced
this pull request
Oct 19, 2021
- now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error.
treee111
added a commit
that referenced
this pull request
Oct 22, 2021
…. Use 'v12' tag (keep) filters (#46) - In the filter stage, do not re-convert the result file(s) back to .osm.pbf format. This saves some time here but more importantly osmconvert is much faster in cutting tiles out of o5m files then .osm.pbf files. - Switched to using 'v12' tag (keep) filters. This only keeps the tags used by Wahoo's devices render themes. Additionally, filter out all names tags except for those used, like city names. So highway names for example or filtered out. - At the start of the splitting phase check for the existence of a merged .osm.pbf file. This prevents unnecessary splitting tiles out of for instance Europe when the tile is already processed from a smaller, so faster, part like Germany. * takeover changes from #40 * osmium does not support writing to o5m format * Introduce Pull Request Template * [FEATURE] Add check for required input parameter for CLI and GUI (#41) - now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error. * [FEATURE] Enhance check for existing (already downloaded) polygons and .osm.pbf files (#43) - use the files modification date, not the creation time. On windows this seemed to occasionally see newly downloaded files as the ones they replaced. - check for a full match instead of doing a wildcard match while checking for existing maps. This prevents matching to multiple maps like australia and australia-oceania. * refactoring (pylint, formatting, comments) - change pylint findings - format constans on save - delete unused comments * don't really know what these lines are doing
treee111
added a commit
that referenced
this pull request
Nov 14, 2021
- Prevents the initialisation of the graphical GUI on WSL. * Introduce Pull Request Template * [FEATURE] Add check for required input parameter for CLI and GUI (#41) - now not only for GUI but also for CLI the country argument is checked - added a check at the start to see if a country is to process is specified. Otherwise closing the GUI without selecting anything resulted in a runtime error. * [FEATURE] Enhance check for existing (already downloaded) polygons and .osm.pbf files (#43) - use the files modification date, not the creation time. On windows this seemed to occasionally see newly downloaded files as the ones they replaced. - check for a full match instead of doing a wildcard match while checking for existing maps. This prevents matching to multiple maps like australia and australia-oceania. * Delete PULL_REQUEST_TEMPLATE.md * Delete wahoo_map_creator.py * Check if we are running in WSl. If so prevent starting the Gui Co-authored-by: Benjamin <benni.kreuscher@gmail.com> Co-authored-by: Benjamin K <53038537+treee111@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #40: