Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to pyhgtmap (fork) for contour lines #217

Open
quietvoid opened this issue Jul 31, 2023 · 2 comments · May be fixed by #234
Open

Consider switching to pyhgtmap (fork) for contour lines #217

quietvoid opened this issue Jul 31, 2023 · 2 comments · May be fixed by #234
Labels
enhancement New feature or request infrastructure Infrastructure

Comments

@quietvoid
Copy link

quietvoid commented Jul 31, 2023

Is your feature request related to a problem? Please describe.

The latest phyghtmap release does not work very well with latest Python and matplotlib versions.
Someone forked it into pyhgtmap however wahoomc has a hardcoded binary to phyghtmap.

Describe the solution you'd like

A way to specify the binary, or maybe setting the default used binary to the new fork while having a fallback to the old version.

Describe alternatives you've considered

Currently I just made a symbolic link, pyhgtmap seems to have backwards compatibility and I was able to create a map.

Unfortunately I think it's not Windows compatible yet: agrenott/pyhgtmap#7

@treee111
Copy link
Owner

treee111 commented Nov 20, 2023

Hi @quietvoid,
thanks for pointing to the fork pyhgtmap! It's a good idea since phyghtmap is difficult to install.

Windows support seams like a blocker for me, so we would have a different tool per OS. With the downsides of enhancing and making documentation more difficult, maybe equalness of results, ...
Supporting both tools for macOS with a switch or "if pyhgtmap is there use it, fallback on phyghtmap" would also have identical downsindes in my opinion.

However I tried it and it works for me on macOS. Feel free to try out the changes in #234 and if it works on your device.

@treee111 treee111 added the infrastructure Infrastructure label Nov 20, 2023
@quietvoid
Copy link
Author

Thanks. I haven't tested but the code looks like it would work.
I don't mind sticking to symbolic links, it works with the current wahoomc code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants