Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] use pyhgtmap instead of phyghtmap for generating contour lines #234

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

treee111
Copy link
Owner

@treee111 treee111 commented Nov 20, 2023

This PR…

Considerations and implementations

Till now, there is no support for Windows, see agrenott/pyhgtmap#7

ToDO

adjust documentation
fix version of pyhgtmap and think of other publish-related stuff for this PR

How to test

  1. create environment gdal-dev-pyh using env .yml file
  2. switch to the environment
  3. swith to this branch
  4. Run wahooMapsCreator and include contour lines using -con
  5. Check if the result is the same as using phyghtmap

Pull Request Checklist

@alfh
Copy link
Contributor

alfh commented Dec 4, 2023

I think we can just use pyhgtmap with "jobs=1", then no forking is attempted, and it should work on windows as well. And then rather use asyncio to launch several instances of pyhgtmap. I'll do some testing on linux first and then on windows.

- to be installed when wahoomc is installed via pip
- to have a environment to test pyhgtmap
- todo: remove documentation about installing phyghtmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider switching to pyhgtmap (fork) for contour lines
2 participants