fix #52: allow enum keys when parsing tables #56
Conversation
There was a problem hiding this comment.
currently jsony can only parse Table with string keys but I do not see any problem to allow a generic key.
I think there is one: a JSON key must be a string. That is, {1: "a"} is invalid JSON.
See:
- The railroad diagrams on https://json.org
- https://www.ecma-international.org/wp-content/uploads/ECMA-404_2nd_edition_december_2017.pdf
To illustrate with other tools:
$ echo '{1: "a"}' | jq
parse error: Object keys must be strings at line 1, column 3
tests/test_tables.nim
Outdated
| var s = """{1:"a"}""" | ||
| var v = s.fromJson(Table[int, string]) |
|
You are right, somehow I got convinced you could have any key (I am working on a yaml parser based on this, so things got mixed up ;)), thanks for the remark! I could fix to only allow string and enum as table keys. Suggestions welcome. |
pietroppeter
changed the title
|
fixed to restrict only to string and enum case. |
|
Not sure if the CI failure (failure when testing with js backend) is related to this fix, at the moment I do not have node locally to test it. |
|
I think your PR fails to due to issue: nim-lang/Nim#21317 |
|
fixed => nim-lang/Nim#21320 |
|
If CI is approved I would expect it to be green |
|
CI is green and ready to merge if approved |
|
sorry it took a while to address your comment, in the end the code was fine as it was but it took me a moment to realize that (see resolved comment above). |
currently jsony can only parse Table with string keys but
I do not see any problem to allow a generic keyenum should be fine too. this fixes #52. added two test case for enum, the second of which replicates issue #52 (enum key). edited to remove possibility of generic keys.