Fix BareExcept warnings on Nim 2.0rc1 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think your PR fails to due to issue: nim-lang/Nim#21317 |
|
@treeform Thanks, I also tried to debug it but then noticed that my PR is not the first that's failing this test. |
|
fixed => nim-lang/Nim#21320 |
|
@ringabout Thanks! |
|
The CI build uses Nim 1.6.12 now, and the tests are green. |
treeform
reviewed
May 2, 2023
| @@ -116,8 +116,8 @@ proc parseHook*(s: string, i: var int, v: var SomeSignedInt) = | |||
| parseHook(s, i, v2) | |||
| try: | |||
| v = type(v)(v2) | |||
| except: | |||
| error("Number type to small to contain the number.", i) | |||
| except CatchableError: | |||
There was a problem hiding this comment.
Is this error actually CatchableError? I have not tested.
Could you make a test case for this and see what the behavior is?
|
Is this important now that the default behavior has changed: nim-lang/Nim#21728 ? |
|
Thank you for the typo fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.