New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angle[T](a, b: GVec2[T]) is wrong #73

Closed

lilkeet opened this issue Jun 24, 2024 · 0 comments

Contributor

lilkeet commented Jun 24, 2024

According to the comment on the subject proc, it should return the angle between two 2D vectors. It currently does not.

import vmath
assert angle(vec2(0.0, 1.0), vec2(1.0, 0.0)).toDegrees() == 135.0 # should be 90
assert angle(vec2(0.0, 1.0), vec2(-1.0, 0.0)).toDegrees() == 45.0 # should be 90
assert angle(vec2(0.0, 1.0), vec2(1.0, 0.0)).toDegrees() == 90.0 # should be 180

lilkeet mentioned this issue

Fix angle proc for 2D vectors #74

Merged

treeform closed this as completed in

57ad916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment