Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate overlays with dialog element #158

Closed
progrium opened this issue May 22, 2023 · 0 comments · Fixed by #186
Closed

consolidate overlays with dialog element #158

progrium opened this issue May 22, 2023 · 0 comments · Fixed by #186
Assignees
@progrium
Milestone
0.4.0

Comments

@progrium
Copy link
Contributor

progrium commented May 22, 2023 •
edited
Loading

Overlays/popovers (menus, notices, search, palette) are all one-offed, but should be combined into a single API. They should also use native <dialog> elements since they simplify and improve tab/focus issues.
@progrium progrium added this to the 0.4.0 milestone May 22, 2023
@progrium progrium self-assigned this May 22, 2023
progrium added a commit that referenced this issue May 30, 2023
@progrium
lib: replaces modal code for quickadd, menus, palette, and notices wi…
9addd1c 
…th single dialog system using the dialog element. the search popover was not ported yet so curtain still remains. closes #158
@progrium progrium mentioned this issue May 30, 2023
Merged
progrium added a commit that referenced this issue May 30, 2023
@progrium
dialogs (#186)
fb4a282 
* lib: replaces modal code for quickadd, menus, palette, and notices with single dialog system using the dialog element. the search popover was not ported yet so curtain still remains. closes #158

* lib: remove toggling dialog command that was for debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@progrium progrium

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

dialogs treehousedev/treehouse
1 participant
@progrium