Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node descriptions #295

Closed
taramk opened this issue Aug 8, 2023 · 1 comment · Fixed by #300
Closed

Node descriptions #295

taramk opened this issue Aug 8, 2023 · 1 comment · Fixed by #300
Assignees
Milestone

Comments

@taramk
Copy link
Contributor

taramk commented Aug 8, 2023

  • description uses color-text-secondary
  • font: [either 12px or 13px], line height 150%
  • command palette > Add Description produces an empty description field with placeholder text “Add Description”. Similarly, command palette should have a "Remove Description" option for nodes that have a description.
  • show description when node is header as well, styled the same but with a slight top margin on the description
  • don’t allow adding descriptions to non-editable nodes (smart node children, for example)

figma:
https://www.figma.com/file/bGzEZo0NYHhWGJO95kwF3p/Treehouse-App?type=design&node-id=504%3A8057&mode=design&t=d6LlVs7KaDchiyNU-1

@taramk taramk added this to the 0.7.0 milestone Aug 8, 2023
@taramk
Copy link
Contributor Author

taramk commented Aug 10, 2023

@progrium i think either 12px or 13px would work, do you have a preference? i initially tried 14px but it's too big, the description should be less obtrusive.

comparisons here:
https://www.figma.com/file/bGzEZo0NYHhWGJO95kwF3p/Treehouse-App?type=design&node-id=505%3A8185&mode=design&t=d6LlVs7KaDchiyNU-1

also, i think descriptions will look fine on most node types. mocked it up on documents and headers as seen here:
https://www.figma.com/file/bGzEZo0NYHhWGJO95kwF3p/Treehouse-App?type=design&node-id=504%3A8057&mode=design&t=d6LlVs7KaDchiyNU-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants