Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: compensate for duplicate nodes in path #288

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ArcaTech
Copy link
Contributor

@ArcaTech ArcaTech commented Aug 2, 2023

When hitting the back button in a panel, there may be a duplicate node id in the path. This change pops again if the node is still in the path, which fixes having to click the button twice.

I started looking into why this is happening the in the first place, but I haven't figured it out yet. I thought it might help to make a command for the "back" behavior and add this there (and maybe also set workspace.lastOpenedID too?), but I didn't know if that made sense to do before figuring out what the actual problem is first. Anyway, I thought I should get this small change out for review now. Let me know what you think @progrium

@progrium
Copy link
Contributor

progrium commented Aug 4, 2023

I think I've noticed we're inconsistent at properly appending to the path and yeah there may be situations it happens twice. This is good for now.

@progrium progrium merged commit b489d66 into treehousedev:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants