lib: compensate for duplicate nodes in path #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting the back button in a panel, there may be a duplicate node id in the path. This change
pop
s again if the node is still in the path, which fixes having to click the button twice.I started looking into why this is happening the in the first place, but I haven't figured it out yet. I thought it might help to make a command for the "back" behavior and add this there (and maybe also set
workspace.lastOpenedID
too?), but I didn't know if that made sense to do before figuring out what the actual problem is first. Anyway, I thought I should get this small change out for review now. Let me know what you think @progrium