treehouses message gitter configure apitoken (fixes #2122)
#2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogi
reviewed
Mar 25, 2021
modules/message.sh
Outdated
Comment on lines
239
to
243
| echo " $BASENAME message gitter apitoken" | ||
| echo " Check for API token for gitter" | ||
| echo | ||
| echo " $BASENAME message gitter authorize \"1234567890\"" | ||
| echo " Sets and saves API token" |
There was a problem hiding this comment.
instead of this:
speak about success
and show api token
JLKwong
requested changes
Mar 27, 2021
modules/message.sh
Outdated
| else | ||
| echo "You do not have a gitter apitoken setup." | ||
| echo "For instructions to configure your gitter apitoken" | ||
| echo "Please run: $BASENAME message gitter apitoken" |
There was a problem hiding this comment.
This error message could also run $BASENAME message gitter apitoken at the end since that's the only decision path and lowers the drop-off rate.
There was a problem hiding this comment.
I will test that out, thanks.
modules/message.sh
Outdated
| get_apitoken gitter | ||
| echo | ||
| echo "You have successfully configured your Gitter apitoken." | ||
| echo "Now you must provide a subcommand for $BASENAME message gitter listed below:" |
There was a problem hiding this comment.
This could also summarize the subcommands in one line:
e.g.
"Now you must provide a subcommand for $BASENAME message gitter [channels|send|show|read|mark] listed below:"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.