menu: add upgrade notification (fixes #536)(fixes #132) #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrijal53
reviewed
Dec 19, 2019
| @@ -192,6 +193,7 @@ private void checkUpgradeStatus() { | |||
| updateRightNow = false; | |||
| pd.dismiss(); | |||
| Toast.makeText(getContext(), "Treehouses Cli has been updated!!!", Toast.LENGTH_LONG).show(); | |||
| InitialActivity.getInstance().setNotification(false); | |||
There was a problem hiding this comment.
@sriharivishnu please use interface callback , instead of getting instance of activity from fragment.
There was a problem hiding this comment.
ok I will change this
sriharivishnu
changed the title
|
@sriharivishnu it is not showing notification.
|
|
@sriharivishnu it appear after i turn off the screen and turned on again. Please fix this issue. |
|
rrijal53
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
@sriharivishnu i mean sometimes the icon is not visible, and it is visible after i turn the screen off and on. We can merge this PR , and fix that issue later.
dogi
approved these changes
Jan 2, 2020
dogi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #536 #132
Performs upgrade check in the home screen, and then uses that result to display a red notification beside the Status icon if there is a new upgrade available.