Verify workflow success in CI on Airflow #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Very neat, thanks! Just a bunch of small but important comments.
I am not sure how the translation works from printing a code in step dag_status_id to failing the action in state Check failed DAG satus. In any case I have a suggestion how to improve the script so that hopefully we won't need this step at all!
Also, please run flake8 on the Python program.
arielshaqed
approved these changes
Feb 22, 2023
FredrikBakken
pushed a commit
to FredrikBakken/airflow-provider-lakeFS
that referenced
this pull request
Aug 13, 2023
* Adding airflow status checker * Adding airflow status checker * Adding airflow package to requirement * Adding the dag run status via API route * Adding the dag run status via API route * Adding the dag auth as user and pass * Adding final kill in case of long running DAG * Added few lines and changed code as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.