Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix merge apply diff closed on error channel #1007

Merged
merged 1 commit into from Dec 6, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Dec 6, 2020

No description provided.

@nopcoder nopcoder added the bug Something isn't working label Dec 6, 2020
@nopcoder nopcoder requested a review from tzahij December 6, 2020 16:10
@nopcoder nopcoder self-assigned this Dec 6, 2020
@nopcoder nopcoder added this to In progress in lakeFS via automation Dec 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #1007 (17d001b) into master (99e89ec) will increase coverage by 0.29%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   44.43%   44.73%   +0.29%     
==========================================
  Files         143      147       +4     
  Lines       11666    11851     +185     
==========================================
+ Hits         5184     5301     +117     
- Misses       5830     5867      +37     
- Partials      652      683      +31     
Impacted Files Coverage Δ
catalog/mvcc/cataloger_merge.go 72.37% <0.00%> (-0.96%) ⬇️
config/config.go 33.54% <42.85%> (+0.44%) ⬆️
pyramid/tierFS.go 59.72% <59.72%> (ø)
pyramid/ro_file.go 71.42% <71.42%> (ø)
pyramid/file.go 76.47% <76.47%> (ø)
pyramid/eviction.go 77.77% <77.77%> (ø)
catalog/mvcc/cataloger_create_entry.go 94.73% <0.00%> (-5.27%) ⬇️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e88f3c7...17d001b. Read the comment docs.

lakeFS automation moved this from In progress to Review in progress Dec 6, 2020
@tzahij tzahij merged commit e86f416 into master Dec 6, 2020
lakeFS automation moved this from Review in progress to Done Dec 6, 2020
@nopcoder nopcoder deleted the bugfix/merge-summary branch February 4, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
lakeFS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants