Bugfix/2307 change error message in lakefs setup #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nopcoder
suggested changes
Sep 1, 2021
talSofer
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Nice!
Please edit the following to the pr description:
- Fixes Non-descriptive error message while trying to create an Admin user more than once #2307 (this automatically closes the issue when you merge the pr)
- fix description. What was the problem, and what solution you implemented.
Agree with @nopcoder . To understand if setup already happened you are checking whether the metadata manager is already initialized which is an implementation detail. as a user I would want the software to speak the language of the actions I'm taking. |
nopcoder
suggested changes
Sep 5, 2021
cmd/lakefs/cmd/setup.go
Outdated
| os.Exit(1) | ||
| } | ||
| if initialized { | ||
| fmt.Printf("Setup is already complete.") |
There was a problem hiding this comment.
Add new-line or use fmt.Println
nopcoder
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #2307
When trying to set up lakeFS more than once, the error message was not descriptive.
I made two changes: