Mark user-visible graveler errors and phrase them for users #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielshaqed
added
pr/merge-if-approved
arielshaqed
force-pushed
the
bugfix/2725-improve-graveler-errors
branch
from
b831c16
to
8d142de
Compare
|
This improves readability of the errors so I'm approving. I still think we can improve the error of the original issue #2725, how hard is it to add the dirty branch name to the error? |
itaiad200
approved these changes
Nov 23, 2021
The easy term for users is "has uncommitted changes", so put that up front. "Dirty" is a useful codeword. Keep it in parentheses at the end, to train users about it.
|
Thanks! After talking f2f, I rephrased and added the name of the failing (dirty) branch to the message. Committing since approved, but happy to revisit if you think it's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725.