lakectl: fixed bug in argument validation #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyaug
added
the
include-changelog
eden-ohana
approved these changes
Apr 10, 2022
johnnyaug
changed the title
arielshaqed
approved these changes
Apr 10, 2022
There was a problem hiding this comment.
Thanks!
AFAICT f7012dd introduced this regression. Can we have a test that will catch the next time we do something like this?
Refs are subtle, and this is a really bad UX.
|
@johnnyaug is it possible to add the test value that will break the previous implementation? |
|
@nopcoder done |
arielshaqed
approved these changes
Apr 17, 2022
esti/lakectl_test.go
Outdated
Comment on lines
140
to
155
| func TestLakectlBranchAndTagValidation(t *testing.T) { | ||
| repoName := generateUniqueRepositoryName() | ||
| storage := generateUniqueStorageNamespace(repoName) | ||
| validTagName := "my.valid.tag" | ||
|
|
||
| vars := map[string]string{ | ||
| "REPO": repoName, | ||
| "STORAGE": storage, | ||
| "BRANCH": mainBranch, | ||
| "TAG": validTagName, | ||
| } | ||
| invalidBranchName := "my.invalid.branch" | ||
| RunCmdAndVerifySuccessWithFile(t, Lakectl()+" repo create lakefs://"+repoName+" "+storage, false, "lakectl_repo_create", vars) | ||
| RunCmdAndVerifyFailureWithFile(t, Lakectl()+" branch create lakefs://"+repoName+"/"+invalidBranchName+" --source lakefs://"+repoName+"/"+mainBranch, false, "lakectl_branch_create_invalid", vars) | ||
| RunCmdAndVerifySuccessWithFile(t, Lakectl()+" tag create lakefs://"+repoName+"/"+validTagName+" lakefs://"+repoName+"/"+mainBranch, false, "lakectl_tag_create", vars) | ||
| } |
There was a problem hiding this comment.
Neat!
Please also test main~3, main~3^2^^, and a few similar ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.