Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template server #3600

Merged
merged 10 commits into from Jul 10, 2022
Merged

Add a template server #3600

merged 10 commits into from Jul 10, 2022

Commits on Jul 3, 2022

  1. Add templater: a facility for expanding templates on demand

    See template-server/template-server.md for design, and ttv-wizard.mvp
    for (first) application.
    arielshaqed committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    c935081 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7aa8754 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2022

  1. Configuration menu
    Copy the full SHA
    b59123b View commit details
    Browse the repository at this point in the history
  2. Add tests

    arielshaqed committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    9786efa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc1eb7b View commit details
    Browse the repository at this point in the history
  4. Fix linter errors

    arielshaqed committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    6961349 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. [CR] Remove requirement to Prepare-and-Expand

    Just have a single Expand call that expands twice, once to `io.Discard` and
    once to the real writer.
    arielshaqed committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b69e6f5 View commit details
    Browse the repository at this point in the history
  2. make gen

    arielshaqed committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    eabbcc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Include S3A endpoint and path-style access in Spark config template

    This should makes it immediately and directly usable.
    
    Co-authored-by: Jonathan Rosenberg <96974219+Jonathan-Rosenberg@users.noreply.github.com>
    arielshaqed and Jonathan-Rosenberg committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    5727ba4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. [BUG] Move template_location to URL path and pass query to templates

    * Move `template_location` to the URL path.  This makes the OpenAPI
      interface cleaner: the URL query now contains just the parameters
      of the template.
    * [CR] Make the `spark.conf.tt` template the finished required form
      including `lakefs_url` in it.
    * Fix **bug** in OpenAPI golang code generation (on both client and
      server sides) with freeform query params in the specification: it
      does not understand `expand: true`.  This is documented as how to
      do it, generates correct URLs in online OpenAPI editors, but code
      generated is incorrect (seems to think the dummy params object is
      actually where it will place the parameters, when in fact it does
      not.
    arielshaqed committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    166e96c View commit details
    Browse the repository at this point in the history