Update project to use Go v1.19.2 #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for pending PR to fix lint issues with deprected APIs. Note we are still not using new features and we are based on 1.17.
nopcoder
added
the
exclude-changelog
N-o-Z
approved these changes
Oct 26, 2022
N-o-Z
requested changes
Oct 26, 2022
itaiad200
approved these changes
Oct 27, 2022
| @@ -1492,7 +1493,8 @@ func listDiffHelper(it EntryDiffIterator, prefix, delimiter string, limit int, a | |||
| } | |||
|
|
|||
| func (c *Catalog) Merge(ctx context.Context, repositoryID string, destinationBranch string, sourceRef string, | |||
| committer string, message string, metadata Metadata, strategy string) (string, error) { | |||
| committer string, message string, metadata Metadata, strategy string, | |||
There was a problem hiding this comment.
was on auto-merge - I'll revert to oneliner in a different pr.
| // // handle err, results, etc.. | ||
| // } | ||
| // | ||
| // func batch(manager RangeManager, bwc BatchWriterCloser) { |
There was a problem hiding this comment.
Why do we need all this whitespace?
There was a problem hiding this comment.
Part of the changes introduced in Go fmt 1.19 - https://tip.golang.org/doc/go1.19.
When you run gofmt -s -w <file> it will apply the above on existing code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4472
Fix #4485