Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signup step back in to Quickstart #5878

Merged
merged 1 commit into from May 16, 2023
Merged

Add signup step back in to Quickstart #5878

merged 1 commit into from May 16, 2023

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented May 15, 2023

Linked Issue

Closes https://github.com/treeverse/devex-internal/issues/259


Change Description

Background

The new quickstart (#5565) removed the initial sign up step, and instead pre-created a user. This change reverses that.

New Feature

No new feature, just removes the pre-creation of the user.

Testing Details

Tested manually.

Breaking Change?

No

@github-actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@github-actions
Copy link

github-actions bot commented May 15, 2023

🎊 PR Preview 9793eea has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-5878.surge.sh

🕐 Build time: 0.014s

🤖 By surge-preview

@rmoff rmoff added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels May 15, 2023
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks! This flow is a bit harder on the user, but the result is better -- at least in terms of security posture.

docs/quickstart/launch.md Show resolved Hide resolved
@rmoff rmoff merged commit fb142a9 into master May 16, 2023
39 of 41 checks passed
@rmoff rmoff deleted the docs/quickstart-email branch May 16, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants