Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate JWT while working with auth API when non is configured #5894

Merged
merged 3 commits into from May 18, 2023
Merged

Generate JWT while working with auth API when non is configured #5894

merged 3 commits into from May 18, 2023

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented May 17, 2023 •
edited

  • Working with auth api service, if no token is configure generate one. we assume that the service require authentication and in the case we configure a shared secret between the two this token can be used.
  • Upgrade jwt package to v4 for auth token only
  • Logging error when auth api fail to perform operations

Close #5902

@nopcoder nopcoder added area/auth IAM, authorization, authentication, audit, AAA, and integrations with all those include-changelog PR description should be included in next release changelog labels May 17, 2023
@nopcoder nopcoder self-assigned this May 17, 2023
Isan-Rivkin
Isan-Rivkin requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some deprecated code issues the CI raised, other than that loved it! just one non-blocker comment!

pkg/auth/service.go Show resolved Hide resolved
@nopcoder
Copy link
Contributor Author

nopcoder commented May 17, 2023 •
edited

There's some deprecated code issues the CI raised, other than that loved it! just one non-blocker comment!

I'll revert some of the changes so there is no change in JWT compatibility with current tokens.

@nopcoder nopcoder requested a review from Isan-Rivkin May 17, 2023 12:51
Isan-Rivkin
Isan-Rivkin approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nopcoder nopcoder merged commit 8b29024 into master May 18, 2023
38 of 40 checks passed
@nopcoder nopcoder deleted the feature/auth-api-gen-token branch May 18, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isan-Rivkin Isan-Rivkin Isan-Rivkin approved these changes

@guy-har guy-har Awaiting requested review from guy-har

Assignees

@nopcoder nopcoder

Labels
area/auth IAM, authorization, authentication, audit, AAA, and integrations with all those include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic JWT for auth API
2 participants
@nopcoder @Isan-Rivkin