Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor auth routes with <Outlet />s #6334

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Refactor auth routes with <Outlet />s #6334

merged 6 commits into from
Nov 15, 2023

Conversation

eladlachmi
Copy link
Contributor

Fixes #6333

@eladlachmi eladlachmi added the include-changelog PR description should be included in next release changelog label Aug 7, 2023
@eladlachmi eladlachmi self-assigned this Aug 7, 2023
@N-o-Z
Copy link
Member

N-o-Z commented Aug 20, 2023

@eladlachmi I tried to get to this PR but I'm unable to do it in the near future - removing myself as to not block

@N-o-Z N-o-Z removed their request for review August 20, 2023 08:18
@eladlachmi eladlachmi force-pushed the 6333-refactor-auth-routes-with-outlets branch from 28c83d6 to 06aae4d Compare September 28, 2023 12:56
guy-har
guy-har approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thanks!

@eladlachmi eladlachmi force-pushed the 6333-refactor-auth-routes-with-outlets branch from 06aae4d to 28fad9a Compare October 29, 2023 10:33
@eladlachmi eladlachmi force-pushed the 6333-refactor-auth-routes-with-outlets branch from 28fad9a to 4dd84e0 Compare November 14, 2023 15:39
@eladlachmi eladlachmi merged commit 60b98cb into master Nov 15, 2023
32 checks passed
@eladlachmi eladlachmi deleted the 6333-refactor-auth-routes-with-outlets branch November 15, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

Assignees

@eladlachmi eladlachmi

Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor auth routes with <Output />
3 participants
@eladlachmi @N-o-Z @guy-har