Fix SeekGE in DDB #6561
Merged
Fix SeekGE in DDB #6561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
added
the
include-changelog
nopcoder
suggested changes
Sep 8, 2023
pkg/kv/dynamodb/main_test.go
Outdated
There was a problem hiding this comment.
Think we can just remove this file and move the code left to the test entry function.
No need global kvparams and etc.
pkg/kv/postgres/main_test.go
Outdated
| @@ -49,7 +48,7 @@ func runDBInstance(dockerPool *dockertest.Pool) (string, func()) { | |||
| // create connection | |||
| var pgPool *pgxpool.Pool | |||
| port := resource.GetPort("5432/tcp") | |||
| uri := fmt.Sprintf("postgres://lakefs:lakefs@localhost:%s/lakefs_db?sslmode=disable", port) | |||
| uri := fmt.Sprintf("postgres://lakefs:lakefs@localhost:%s/%s?sslmode=disable", port, dbName) | |||
There was a problem hiding this comment.
wrap dbName with call to url.PathEscape
There was a problem hiding this comment.
Suggest to keep the same database name and have each test create a different db or scheme on the same instance.
nopcoder
reviewed
Sep 10, 2023
Co-authored-by: Barak Amar <barak.amar@treeverse.io>
nopcoder
suggested changes
Sep 10, 2023
|
|
||
| // create a new schema per test | ||
| schemaName := "test_schema" + testutil.UniqueName() | ||
| _, err = conn.Exec(context.Background(), fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s;", schemaName)) |
There was a problem hiding this comment.
Use connection's QuoteIdentifier to quote the schemaName value.
Check the following if it works:
Suggested change
| _, err = conn.Exec(context.Background(), fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s;", schemaName)) | |
| _, err = conn.Exec(ctx, "CREATE SCHEMA IF NOT EXISTS " + conn. QuoteIdentifier(schemaName)) |
There was a problem hiding this comment.
Can't. I simply escaped it
pkg/kv/postgres/store_test.go
Outdated
| schemaName := "test_schema" + testutil.UniqueName() | ||
| _, err = conn.Exec(context.Background(), fmt.Sprintf("CREATE SCHEMA IF NOT EXISTS %s;", schemaName)) | ||
| if err != nil { | ||
| t.Fatalf("Error creating schema: %v", err) |
There was a problem hiding this comment.
Suggested change
| t.Fatalf("Error creating schema: %v", err) | |
| t.Fatalf("Error creating schema '%s': %s", schemaName, err) |
pkg/kv/postgres/store_test.go
Outdated
|
|
||
| store, err := kv.Open(ctx, kvparams.Config{ | ||
| Type: postgres.DriverName, | ||
| Postgres: &kvparams.Postgres{ConnectionString: databaseURI, ScanPageSize: 10}, | ||
| Postgres: &kvparams.Postgres{ConnectionString: fmt.Sprintf("%s&search_path=%s", databaseURI, schemaName), ScanPageSize: kvtest.MaxPageSize}, |
There was a problem hiding this comment.
Need to url parse the connection string to add qs parameter
nopcoder
approved these changes
Sep 10, 2023
…keFS into 6558-import-ddb-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6558