Add TTL to STS #7605
Merged
Add TTL to STS #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ PR Preview 2421a3f has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
guy-har
changed the title
guy-har
added
the
include-changelog
guy-har
changed the title
guy-har
force-pushed
the
chore/add-ttl-to-sts
branch
from
8f0a0c1
to
8211282
Compare
guy-har
changed the title
idanovo
requested changes
Apr 2, 2024
| type: integer | ||
| format: int64 | ||
| description: | | ||
| The time-to-live for the generated token in seconds. The maximum |
There was a problem hiding this comment.
I'm not sure I understand the second sentence here
| @@ -1818,7 +1824,7 @@ paths: | |||
| post: | |||
| tags: | |||
| - experimental | |||
| operationId: STSLogin | |||
| operationId: stsLogin # change to stsLogin | |||
| @@ -536,7 +539,7 @@ func (c *Controller) Login(w http.ResponseWriter, r *http.Request, body apigen.L | |||
| expires := loginTime.Add(duration) | |||
| secret := c.Auth.SecretStore().SharedSecret() | |||
|
|
|||
| tokenString, err := GenerateJWTLogin(secret, user.Username, loginTime.Unix(), expires.Unix()) | |||
There was a problem hiding this comment.
now you're changing it back? 😅
Comment on lines
+1069
to
+1070
| The time-to-live for the generated token in seconds. The maximum | ||
| value is 3600 seconds (1 hour) max is 12 hours. |
There was a problem hiding this comment.
Suggested change
| The time-to-live for the generated token in seconds. The maximum | |
| value is 3600 seconds (1 hour) max is 12 hours. | |
| The time-to-live for the generated token in seconds. | |
| The default value is 3600 seconds (1 hour) maximum time allowed is 12 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes: