Feature/python wrapper sts #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview e0d17c0 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7620.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
guy-har
force-pushed
the
feature/python-wrapper-sts
branch
2 times, most recently
from
e0d17c0
to
4d9db18
Compare
E2E Test Results - DynamoDB Local - Local Block Adapter |
guy-har
added
the
include-changelog
N-o-Z
requested changes
Apr 3, 2024
| @@ -106,6 +106,17 @@ def version(self) -> str: | |||
| return self._server_conf.version | |||
|
|
|||
|
|
|||
| def from_web_identity(code: str, state: str, redirect_uri: str, ttl_seconds: int = 3600, **kwargs) -> Client: | |||
| """ | |||
There was a problem hiding this comment.
Our docstrings generate our documentation. Please add verbose documentation and document parameters as well
Comment on lines
117
to
118
| client.config.access_token = auth_token.token | ||
| return client |
There was a problem hiding this comment.
Doesn't need to be under the exception handling
Suggested change
| client.config.access_token = auth_token.token | |
| return client | |
| client.config.access_token = auth_token.token | |
| return client |
guy-har
force-pushed
the
feature/python-wrapper-sts
branch
from
7e95dcd
to
1d8f1f7
Compare
N-o-Z
reviewed
Apr 3, 2024
| :param redirect_uri: The redirect URI used in the authentication process | ||
| :param ttl_seconds: The token's time-to-live in seconds | ||
| :param kwargs: Remaining arguments for the Client object | ||
| :return: The authenticated Client object |
There was a problem hiding this comment.
Please add :raises: according to definition in swagger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.