Fix storage config loading state not updated

[eladlachmi]

Closes #7249

Change Description

Background

Please refer to the linked issue for a full description of the bug.

Root Cause and Solution

There are actually two issues here, which manifest in the same way:

1. loading property not updated

The object viewer initially renders in a loading state. The useStorageConfig context hook re-renders the component when the storage config is loaded (from server or memory). During it's render, the component checks config.loading. In the initial state of the context, loading is set to true. However, when setting the state received from the server, the loading property isn't set, so the component re-renders into the same loading state.

To fix this issue we spread the server response object and add a loading property with a value false. Once config.loading is set to false, the object viewer component re-renders correctly.

2. The useEffect hook in the storage config context was missing a dep on the logged in user

When there is no logged in user, fetchStorageConfig rejects with HTTP status 401. Since there was a missing dependency, the useEffect hook would never trigger a re-render of the context value and thus not trigger a re-render of components that use it. Adding the user from the useUser hook to the dependencies array triggers the chain of re-renders as expected.

[github-actions]

E2E Test Results - DynamoDB Local - Local Block Adapter

[N-o-Z]

Thanks! Was waiting for this one :)

[itaiad200]

@eladlachmi my understanding of the root cause is different, let me know what I missed. AFAIU when the user isn't logged in the storage-provider is still being called and returns 401, hence not setting it. Once the user is logged in, the storage-provider isn't being called again therefore it is stuck in a loading state. I don't see how this change fixes the problem during logins.

[eladlachmi]

@itaiad200 You're right. Those are two separate issues that manifest with the same symptoms. On it...

[itaiad200]

@itaiad200 You're right. Those are two separate issues that manifest with the same symptoms. On it...

The issue has 2 root causes? That's rare. How was this tested? I believe the issue isn't resolved by these fixes

[eladlachmi]

The issue has 2 root causes?

@itaiad200
No. Two different issues end up with the same final result, i.e., they render the same HTML output.
Case no. 1: config has values, but loading is undefined after fetch. The component re-renders back into the loading state.
Case no. 2: config doesn't have values, because it doesn't re-fetch after login. The component doesn't re-render at all, so it remains in the loading state.

How was this tested?

This was tested manually and by the E2E tests that are part of this PR.

I believe the issue isn't resolved by these fixes

Maybe... How was this belief tested?

[itaiad200]

The issue has 2 root causes?

@itaiad200 No. Two different issues end up with the same final result, i.e., they render the same HTML output. Case no. 1: config has values, but loading is undefined after fetch. The component re-renders back into the loading state. Case no. 2: config doesn't have values, because it doesn't re-fetch after login. The component doesn't re-render at all, so it remains in the loading state.

How was this tested?

This was tested manually and by the E2E tests that are part of this PR.

I believe the issue isn't resolved by these fixes

Maybe... How was this belief tested?

I experimented with this issue before. I alo checked out this branch and was able to reproduce the issue. I might have configured something wrong, but from my previous tries, the StorageProvider needs to be called again after a successful login. I don't know React well enough to understand the deps/context handling and if it happens in this fix.

[eladlachmi]

the StorageProvider needs to be called again after a successful login. I don't know React well enough to understand the deps/context handling and if it happens in this fix.

Yeah, that's exactly what this change does

[itaiad200]

Thank you for your patience throughout this PR.