Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walk over hidden files in lakectl local #7644

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Walk over hidden files in lakectl local #7644

merged 2 commits into from
Apr 9, 2024

Conversation

arielshaqed
Copy link
Contributor

This was mistakenly removed. Tests in next commit.

Fixes #7641.

@arielshaqed arielshaqed requested a review from N-o-Z April 9, 2024 11:32
@arielshaqed arielshaqed added bug Something isn't working contributor include-changelog PR description should be included in next release changelog lakectl-local labels Apr 9, 2024
@arielshaqed
Copy link
Contributor Author

Although this changes behaviour of lakectl local -- it now works with "hidden" files -- I regard this as a bug fix. Originally we did not have this behaviour, then we regressed. Accordingly this is not a major or even minor version bump, just a patch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

N-o-Z
N-o-Z approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great!

@arielshaqed
Copy link
Contributor Author

Thanks! Pulling...

@arielshaqed arielshaqed merged commit ac29208 into master Apr 9, 2024
42 of 43 checks passed
@arielshaqed arielshaqed deleted the bug/7641-local-hidden branch April 9, 2024 11:48
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
@arielshaqed
Walk over hidden files in lakectl local (treeverse#7644)
b222377 
* [local] Walk over hidden files in `lakectl local`

This was mistakenly removed.  Tests in next commit.

Fixes treeverse#7641.

* Test hidden files with `lakectl local`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees
No one assigned
Labels
bug Something isn't working contributor include-changelog PR description should be included in next release changelog lakectl-local
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lakectl local ignores "hidden" files
2 participants
@arielshaqed @N-o-Z