Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 gateway - return slowdown on DynamoDB throttle #7685

Merged
merged 2 commits into from
Apr 17, 2024
Merged

S3 gateway - return slowdown on DynamoDB throttle #7685

merged 2 commits into from
Apr 17, 2024

Conversation

guy-har
Copy link
Contributor

@guy-har guy-har commented Apr 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@github-actions GitHub Actions
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Jonathan-Rosenberg
Jonathan-Rosenberg approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, was this tested to make sure that popular clients, like Spark, behave as expected?
What about programmatic tests?

@guy-har guy-har changed the title Chore/slowdown on throttle S3 gateway - return slowdown on DynamoDB throttle Apr 17, 2024
@guy-har guy-har added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Apr 17, 2024
@guy-har guy-har mentioned this pull request Apr 17, 2024
Open
@guy-har
Copy link
Contributor Author

guy-har commented Apr 17, 2024

Thanks @Jonathan-Rosenberg
Opened #7686

@guy-har guy-har merged commit 52cbed0 into master Apr 17, 2024
37 of 41 checks passed
@guy-har guy-har deleted the chore/slowdown-on-throttle branch April 17, 2024 14:56
@guy-har guy-har mentioned this pull request Apr 24, 2024
Closed
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
@guy-har
S3 gateway - return slowdown on DynamoDB throttle (treeverse#7685)
ff95a7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonathan-Rosenberg Jonathan-Rosenberg Jonathan-Rosenberg approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guy-har @Jonathan-Rosenberg