Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close resp body in lua s3 client #7703

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix: close resp body in lua s3 client #7703

merged 1 commit into from
Apr 30, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 29, 2024 •
edited by itaiad200

Body response is not closed in lua aws s3 client

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

itaiad200
itaiad200 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@itaiad200 itaiad200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix!

@itaiad200 itaiad200 added include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached labels Apr 30, 2024
@itaiad200 itaiad200 changed the title fix: close resp body fix: close resp body in lua s3 client Apr 30, 2024
@itaiad200 itaiad200 merged commit 5826acf into treeverse:master Apr 30, 2024
40 of 42 checks passed
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
@testwill
fix: close resp body (treeverse#7703)
53c96c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaiad200 itaiad200 itaiad200 approved these changes

Assignees
No one assigned
Labels
include-changelog PR description should be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@testwill @CLAassistant @itaiad200