Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDB temp creds to refresh before expiry #7718

Merged
merged 4 commits into from
May 5, 2024
Merged

Conversation

itaiad200
Copy link
Contributor

closes #7717

@itaiad200 itaiad200 requested a review from a team May 3, 2024 11:46
Copy link
Contributor

@Jonathan-Rosenberg Jonathan-Rosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
I wonder if there are other AWS clients that we should add this to...
You have some linting errors

Copy link

github-actions bot commented May 5, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@itaiad200 itaiad200 added the include-changelog PR description should be included in next release changelog label May 5, 2024
@itaiad200 itaiad200 merged commit 8049b70 into master May 5, 2024
36 of 37 checks passed
@itaiad200 itaiad200 deleted the 7717-ddb-refresh-creds branch May 5, 2024 10:35
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
* make sure creds are refreshed before expiry

* small fix

* small fix

* small fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When using DDB with AWS roles, token is refreshed after expiry
2 participants